Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PyPy builds #28

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Support PyPy builds #28

merged 1 commit into from
Feb 18, 2021

Conversation

milesgranger
Copy link
Owner

@milesgranger milesgranger commented Feb 18, 2021

Adds PyPy36 support.

@milesgranger milesgranger marked this pull request as ready for review February 18, 2021 11:06
@milesgranger
Copy link
Owner Author

@martindurant is this helpful at all for our conda recipe issues? Just missing Window's PyPy...

@martindurant
Copy link

Good enough for me! I'm not going to stretch too far for pypy, especially since fastparquet, the first user of cramjam, dopesn't run on pypy anyway (because of numba).

@martindurant
Copy link

As far as conda-forge is concerned, let's release a new version with the allocation updates sooner rather than later. Perhaps should open a new issue of things we'd like to see happen by that release.

@milesgranger
Copy link
Owner Author

Great, was going to merge this then #26 if you're good with that.
Is it also okay with a 2.0.0-rc2 prerelease, as would still like to do some minor housekeeping; although admittedly nothing that would affect the major/minor version I guess.

@milesgranger milesgranger merged commit e94b30f into master Feb 18, 2021
@milesgranger milesgranger deleted the pypy-install branch February 18, 2021 14:13
@martindurant
Copy link

Is it also okay with a 2.0.0-rc2 prerelease

I've never done this. For pydata packages, most just inc the smallest number as seems fit. We don't strictly semantic-version, and indeed many are coving to calendar-version to avoid any confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants